Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Videoconf message actions #30456

Merged
merged 4 commits into from
Sep 22, 2023
Merged

regression: Videoconf message actions #30456

merged 4 commits into from
Sep 22, 2023

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Sep 21, 2023 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

TC-965

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ebe25bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh gabriellsh changed the title regression: Remove "Reply in direct message action" for videoconferences regression: "Reply in direct message" showing for videoconferences Sep 21, 2023
@gabriellsh gabriellsh changed the title regression: "Reply in direct message" showing for videoconferences regression: Videoconf message actions Sep 21, 2023
guijun13
guijun13 previously approved these changes Sep 21, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #30456 (ebe25bf) into release-6.4.0 (ec60dbe) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.4.0   #30456      +/-   ##
=================================================
- Coverage          50.09%   50.03%   -0.07%     
=================================================
  Files                775      775              
  Lines              14491    14491              
  Branches            2618     2618              
=================================================
- Hits                7259     7250       -9     
+ Misses              6839     6832       -7     
- Partials             393      409      +16
Flag Coverage Δ
e2e 48.43% <ø> (-0.07%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 22, 2023
@kodiakhq kodiakhq bot merged commit ac48589 into release-6.4.0 Sep 22, 2023
@kodiakhq kodiakhq bot deleted the reg/replyDirect branch September 22, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guijun13 guijun13 guijun13 approved these changes

Assignees
No one assigned
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabriellsh @guijun13 @jessicaschelly @ggazzo